feat(Sources): added non-paginated layout#802
Merged
nicolethoen merged 4 commits intopatternfly:mainfrom Feb 11, 2026
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-802.surge.sh A11y report: https://chatbot-pr-chatbot-802-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss657_multiSourceLayout
branch
from
6b10557 to
0f9062d
Compare
|
This looks good! |
nicolethoen
reviewed
Feb 10, 2026
| <ExpandableSection | ||
| variant={ExpandableSectionVariant.truncate} | ||
| toggleTextCollapsed={showLessWords} | ||
| toggleTextExpanded={showMoreWords} |
Contributor
There was a problem hiding this comment.
Are these backward? should the toggleTextCollapsed use the showMoreWords?
| isCompact={isCompact} | ||
| className="pf-chatbot__sources-card" | ||
| style={{ maxWidth: cardMaxWidth }} | ||
| component="span" |
Contributor
There was a problem hiding this comment.
Why is this component a span? if it had 'divs' in it, i think it should be a div.
Collaborator
Author
There was a problem hiding this comment.
Ah yeah I made this span because the ListItem component wraps its children in a span so was trying to avoid this being a div inside that. Made updates to just use native elements instead of our List components to get around that.
thatblindgeye
force-pushed
the
iss657_multiSourceLayout
branch
from
f01bb2e to
e55d09c
Compare
nicolethoen
approved these changes
Feb 11, 2026
|
🎉 This PR is included in version 6.6.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #657